Merging to release-5-lts: [TT-13819] Benchmark updates, session limiter workaround for test goroutine leak (#6826) #6832
+96
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outine leak (#6826) Enhancement, Tests ___ - Added `DisableRateLimit` and `DisableQuota` flags in multiple test cases. - Improved benchmark scripts and added skipping for specific benchmarks. - Refactored session limiter to encourage reuse of `bucketStore`. - Updated CI benchmark script for better profiling and output. ___ <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>api_definition_test.go</strong><dd><code>Added <code>DisableRateLimit</code> and <code>DisableQuota</code> flags in API definition tests</code></dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-2394daab6fdc5f8dc234699c80c0548947ee3d68d2e33858258d73a8b5eb6f44">+2/-0</a> </td> </tr> <tr> <td><strong>event_system_test.go</strong><dd><code>Added benchmark skipping for generic event handlers</code> </dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-59fda3ebcb87e3c16f222e51988dfb18be9239c84caeef0137db04ffe9ab8f3c">+2/-0</a> </td> </tr> <tr> <td><strong>mw_basic_auth_test.go</strong><dd><code>Added `DisableRateLimit` and `DisableQuota` flags in basic auth tests</code></dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-148b4d4c5c77fa4382e83fd583c36d21bba7b52217f821095abbc517d277b16f">+2/-1</a> </td> </tr> <tr> <td><strong>mw_jwt_test.go</strong><dd><code>Added `DisableRateLimit` and `DisableQuota` flags in JWT tests</code></dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-406bf8fdb6c0cc77f04c6245c70abfc592ddb1525aa843200d850e14d135ebfc">+10/-0</a> </td> </tr> <tr> <td><strong>mw_transform_test.go</strong><dd><code>Refactored transform middleware benchmarks for better structure</code></dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-ec6f80b3dcb001b2a2ac9b7277fff606bd77d796f99b8c1d10b8d0d55863deb3">+9/-7</a> </td> </tr> <tr> <td><strong>oauth_manager_test.go</strong><dd><code>Added benchmark skipping for OAuth token purging</code> </dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-139c3beb238f234728bde9f619f501cf730a7e275d17c8511277272d1dcd6fc6">+2/-0</a> </td> </tr> <tr> <td><strong>res_handler_header_injector_test.go</strong><dd><code>Adjusted header injection benchmarks and test cases</code> </dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-1c82da1ac85593e31ce947ef821703967ceb8065a5434c6749b802a1b93f9117">+7/-6</a> </td> </tr> </table></details></td></tr><tr><td><strong>Enhancement</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>session_manager.go</strong><dd><code>Refactored session limiter to reuse `bucketStore`</code> </dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-e6b40a285464cd86736e970c4c0b320b44c75b18b363d38c200e9a9d36cdabb6">+4/-1</a> </td> </tr> <tr> <td><strong>ci-benchmark.sh</strong><dd><code>Enhanced CI benchmark script with profiling and output improvements</code></dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-e789974499a5ba77194df612e751bc3db20b73c389466c679e4e74521199dd48">+9/-3</a> </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>CODEOWNERS</strong><dd><code>Updated ownership for `/bin/` directory</code> </dd></td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6826/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7">+1/-0</a> </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit 155e11b)
|
API Changes no api changes detected |
💥 CI tests failed 🙈git-stateall okPlease look at the run or in the Checks tab. |
|
Let's make that PR title a 💯 shall we? 💪 Your PR title and story title look slightly different. Just checking in to know if it was intentional!
Check out this guide to learn more about PR best-practices. |
💥 CI tests failed 🙈git-stateall okPlease look at the run or in the Checks tab. |
|
@lghiur merge exception please, test flaky, unrelated to change, requires api-tests which are missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-13819
TT-13819 Benchmark updates, session limiter workaround for test goroutine leak (#6826)
PR Type
Enhancement, Tests
Description
Added
DisableRateLimitandDisableQuotaflags in multiple testcases.
Improved benchmark scripts and added skipping for specific benchmarks.
Refactored session limiter to encourage reuse of
bucketStore.Updated CI benchmark script for better profiling and output.
Changes walkthrough 📝
7 files
AddedDisableRateLimitandDisableQuotaflags in API definition testsAdded benchmark skipping for generic event handlersAdded `DisableRateLimit` and `DisableQuota` flags in basic auth testsAdded `DisableRateLimit` and `DisableQuota` flags in JWT testsRefactored transform middleware benchmarks for better structureAdded benchmark skipping for OAuth token purgingAdjusted header injection benchmarks and test cases2 files
Refactored session limiter to reuse `bucketStore`Enhanced CI benchmark script with profiling and output improvements1 files
Updated ownership for `/bin/` directoryCo-authored-by: Tit Petric tit@tyk.io