Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add glob to webhook definition #345

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat: add glob to webhook definition #345

merged 2 commits into from
Jan 24, 2024

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Jan 22, 2024

Adds a glob to the webhook definition, to allow the JSON WebhookDefinition to include a catch-all that is sent every order and order update.

@zzmp zzmp force-pushed the wildcard-webhook branch from 12bcf20 to 15920b8 Compare January 22, 2024 22:08
Copy link
Contributor

@rileydcampbell rileydcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm. Just couple comments.

test/providers/s3-webhook-provider.test.ts Show resolved Hide resolved
lib/providers/json-webhook-provider.ts Outdated Show resolved Hide resolved
@zzmp zzmp requested a review from rileydcampbell January 24, 2024 18:43
Copy link
Contributor

@rileydcampbell rileydcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzmp zzmp merged commit 3f023e7 into main Jan 24, 2024
3 checks passed
@zzmp zzmp deleted the wildcard-webhook branch January 24, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants