Skip to content

CHANGE: Allow (internal) input module to define input event packing alignment #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

CHANGE: Allow (internal) input module to define input event packing alignment #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efa494d
Added version based define for availability of constant in internal m…
ekcoh May 6, 2025
f3f103b
Need to bump version in asmdef to not cause problems with trunk CI runs
ekcoh May 6, 2025
432e3d9
Merge branch 'develop' into isx-2279-spike-module-dependency
ekcoh May 13, 2025
5802bb7
Merge branch 'develop' into isx-2279-spike-module-dependency
ekcoh Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Packages/com.unity.inputsystem/InputSystem/Events/InputEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,20 @@ public struct InputEvent
/// </summary>
public const int InvalidEventId = 0;

#if UNITY_INPUT_SYSTEM_INPUT_MODULE_DEFINES_EVENT_PACKING_ALIGNMENT
/// <summary>
/// Defines the packing alignment of native input events in event buffers.
/// </summary>
/// <remarks>
/// This is dictated by the native module implementation which populates the event buffers.
/// </remarks>
internal const int kAlignment = NativeInputEvent.alignment;
#else
/// <summary>
/// Defines the packing alignment of native input events in event buffers.
/// </summary>
internal const int kAlignment = 4;
#endif

[FieldOffset(0)]
private NativeInputEvent m_Event;
Expand Down
5 changes: 5 additions & 0 deletions Packages/com.unity.inputsystem/InputSystem/Unity.InputSystem.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@
"name": "com.unity.modules.unityanalytics",
"expression": "1",
"define": "UNITY_INPUT_SYSTEM_ENABLE_ANALYTICS"
},
{
"name": "Unity",
"expression": "6000.3.0",
"define": "UNITY_INPUT_SYSTEM_INPUT_MODULE_DEFINES_EVENT_PACKING_ALIGNMENT"
}
],
"noEngineReferences": false
Expand Down