FIX: Impossibility to set InputSystemUIInputModule.localMultiPlayerRoot to null #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new test to verify UI navigation and submit actions using a gamepad when the event system's playerRoot (localMultiPlayerRoot) is set and when it is null. Ensures navigation and submit functionality work correctly in both scenarios.
|
|
hannem-rythmos
changed the title
hannem-rythmos
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2222 +/- ##
===========================================
- Coverage 68.11% 68.10% -0.01%
===========================================
Files 367 367
Lines 53629 53628 -1
===========================================
- Hits 36529 36526 -3
- Misses 17100 17102 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
LeoUnity
approved these changes
Aug 8, 2025
5 tasks
ekcoh
approved these changes
Aug 18, 2025
|
Branch needs an update based on develop and then a CI re-run to land. Seems like QA review is also pending. |
jfreire-unity
approved these changes
Aug 18, 2025
|
@hannem-rythmos do you have any suggestions on how I should test this one? I've tried setting it to null and I'm unable to with and without the PR, I must be doing something wrong |
|
Hi @Pauliusd01 , could you please share the repro steps you tried? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Case ISXB-1610] (https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1610)
This PR removes the null check in MultiplayerEventSystem.InitializePlayerRoot() that prevented setting InputSystemUIInputModule.localMultiPlayerRoot to null. We found that the check was introduced in PR #1547, but no specific reason was provided
Since localMultiPlayerRoot is already safely used (e.g., in IsMoveAllowed() via its own null check), we have removed the null check.
Testing status & QA
Added a UnityTest to validate that setting InputSystemUIInputModule.localMultiPlayerRoot to null allows full UI navigation as expected.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
As localMultiPlayerRoot is having its own null check, we have removed the PlayerRoot null check in InitializePlayerRoot().
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: