Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixed fetch favorite post status code successfully issue 570 #585

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Aug 9, 2024

Pull Request Resolves [ #570 ]

Title: Fixed fetch favorite post status code successfully.

Description

  1. In frontend, I am calling the status code for favorite when user is login only.
  2. Because of this the api is never hit when other users hit the page.

Related Issues

Fixes #570

Changes Made

Bug fixe: Fixed fetch favorite post status code.

Screenshots

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 9:58am

Copy link

github-actions bot commented Aug 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VaibhavArora314
Copy link
Owner

VaibhavArora314 commented Aug 9, 2024

Only this much change solves the bug? I am marking this as level 1 then.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 9, 2024

Only this much change solves the bug? I am marking this as level 1 then.

I was not just solving the bug, but the searching the bug and where the bug is located also testing with multiple accounts is the main effort !

@VaibhavArora314 VaibhavArora314 merged commit 2913d0a into VaibhavArora314:main Aug 9, 2024
4 checks passed
Copy link

github-actions bot commented Aug 9, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Showing the favourite status failed when style share is open in logout account
3 participants