-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added post search suggestion when search on searchbar successfully issue 586 #591
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@VaibhavArora314 Please give level 3 if possibe after evaluation due to frontend + backend integration 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, a request is sent for every letter typed or removed from the search input. Maybe you can use a setTimeout to call the API after like 300ms and if the user changes something in the search query within those 300ms, then you can clear the previous timeout and set a new timeout for the API call after 300ms. This process of clearing timeout will keep on going on until the user stops changing the search query and then results will be shown.
If it's too much then tell me here, I will merge it under level 2. |
Nice optimal solution, I am doing it @VaibhavArora314 👍 |
@VaibhavArora314 Done with the changes as requested 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaibhavArora314 Done 💯 |
Comment axios default baseurl logic |
Opps, In hurry I totally forgot about that, my bad : |
@VaibhavArora314 please merge my PRS only 2 hours is remaining Thank YOU 👍 |
@akbatra567 kindly review and merge this as soon as possible |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Pull Request Resolves [ #586 ]
Title: Added post search suggestion when search on searchbar successfully.
Description
Related Issues
Fixes #586
Changes Made
New feature: Added post search suggestion when search on searchbar.
Screenshots
Video
Style.Share._.Our.Posts.-.Google.Chrome.2024-08-10.01-58-53.online-video-cutter.com.mp4
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.