Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google and other login feature are implimented #79

Conversation

ManishBirthlia
Copy link

@ManishBirthlia ManishBirthlia commented Jun 2, 2024

Pull Request

Title

Google Sign-Up Feature Implementation and Re-Designing the Sign-Up and Login Form

Description

I tried out this new library called @kinde-oss/kinde-auth-react. I didn't replace your authentication code, just commented it out and added my code. I didn't delete or modify any existing code, just added new login and sign-in buttons.

Related Issues

Fixes #52
Fixes #64
Fixes #63
Fixes #46

Changes Made

  • I Have Commneted your previous Sign In and Sign up code in "Navbar.jsx" onced opened you will able to understand
  • Mostly changes I have done in "Navbar.jsx" and then I changed "isLoggedIn" to "isAuthenticated" which is an in-build
  • I have just used this new library "@kinde-oss/kinde-auth-react"

Checklist

  • Google Login
  • Facebook Login
  • Twitter Login
  • Github Login
  • Microsoft Login
  • Apple Login
  • Linkedin Login
  • Discord Login
  • I have tested the changes locally
  • Changes are backward-compatible
  • Everything working Properly

Screenshots (if applicable)

Style.Share.mp4

Additional Notes

@VaibhavArora314 you have to make an account on Kinde and provide your Client ID and Domain and then you will be able to see all these changes 😉

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 10:26am

Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@ManishBirthlia
Copy link
Author

@VaibhavArora314 This is the Preview website you can go to see and tell me what you think about it
https://style-share-git-fork-manishbi-1bad6d-vaibhavs-projects-0c395dc9.vercel.app/app/

@VaibhavArora314
Copy link
Owner

hey so first of all don't work on any issue unless it's assigned to you as there can be others assigned the same issue already and it can cause your work to be wasted.

secondly, the auth logic implemented redirects the user to the Kinde website where authentication is handled but we wanted it to be integrated within our own website

@ManishBirthlia
Copy link
Author

hey so first of all don't work on any issue unless it's assigned to you as there can be others assigned the same issue already and it can cause your work to be wasted.

secondly, the auth logic implemented redirects the user to the Kinde website where authentication is handled but we wanted it to be integrated within our own website

Yes exactly that's why i asked you if you want this or not then you reply with that you are open to new things but np🙌 i also learned a lot from your project so no worries and i will keep in mind to worked only if i am assigned to it 😂

@VaibhavArora314
Copy link
Owner

hey so first of all don't work on any issue unless it's assigned to you as there can be others assigned the same issue already and it can cause your work to be wasted.
secondly, the auth logic implemented redirects the user to the Kinde website where authentication is handled but we wanted it to be integrated within our own website

Yes exactly that's why i asked you if you want this or not then you reply with that you are open to new things but np🙌 i also learned a lot from your project so no worries and i will keep in mind to worked only if i am assigned to it 😂

sorry for any confusion, but when I checked out their website I did not know they will use their website as the mediator 😅

@ManishBirthlia
Copy link
Author

sorry for any confusion, but when I checked out their website I did not know they will use their website as the mediator 😅

Yea and np yaar besides understanding your project which i always love to do 😉 implementing login features using Kinde is hardly any problem

@VaibhavArora314
Copy link
Owner

VaibhavArora314 commented Jun 2, 2024

sorry for any confusion, but when I checked out their website I did not know they will use their website as the mediator 😅

Yea and np yaar besides understanding your project which i always love to do 😉 implementing login features using Kinde is hardly any problem

feel free to raise any issues, I will be happy to assign them to you. also, there are some issues I raised which are not assigned to anyone yet #66, #55

@ManishBirthlia
Copy link
Author

@VaibhavArora314 i would have happily taken these issues but i have to build a complete project using Shephard liberary because i joined a Quest in SSOC'24 and there is prize money for completing the Quest 😅😂..... So i will come back to raise more issues on your project 🙌👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants