Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize renderer pipeline #14

Closed

Conversation

lburgazzoli
Copy link

@lburgazzoli lburgazzoli commented Oct 16, 2024

Requires #15

@lburgazzoli lburgazzoli force-pushed the kustomize_pipeline branch 2 times, most recently from bb6b842 to 3123a44 Compare October 16, 2024 16:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 34.83965% with 447 lines in your changes missing coverage. Please review.

Please upload report for BASE (initialize_api@0dd28c9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controllers/components/dashboard_controller.go 0.00% 105 Missing ⚠️
pkg/controller/actions/action_deploy.go 0.00% 82 Missing ⚠️
pkg/utils/test/matchers/jq/jq_support.go 29.33% 47 Missing and 6 partials ⚠️
pkg/utils/test/matchers/yq/yq_support.go 42.10% 29 Missing and 4 partials ⚠️
pkg/manifests/kustomize/kustomize_render_opts.go 34.14% 27 Missing ⚠️
...ntroller/actions/action_deploy_merge_deployment.go 55.55% 12 Missing and 12 partials ⚠️
pkg/manifests/kustomize/kustomize_engine.go 57.14% 8 Missing and 7 partials ⚠️
pkg/utils/test/matchers/yq/yq_matcher.go 36.36% 9 Missing and 5 partials ⚠️
pkg/controller/actions/action_render_manifests.go 80.00% 8 Missing and 5 partials ⚠️
pkg/utils/test/matchers/jq/jq_matcher.go 43.47% 9 Missing and 4 partials ⚠️
... and 9 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##             initialize_api      #14   +/-   ##
=================================================
  Coverage                  ?   22.44%           
=================================================
  Files                     ?       62           
  Lines                     ?     3537           
  Branches                  ?        0           
=================================================
  Hits                      ?      794           
  Misses                    ?     2626           
  Partials                  ?      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli
Copy link
Author

We finally have a good dependency tree:

kubectl tree datascienceclusters.datasciencecluster.opendatahub.io default-dsc --all-namespaces
NAMESPACE    NAME                                                 READY  REASON  AGE
             DataScienceCluster/default-dsc                       -              63m
             └─Dashboard/default-dashboard                        True   Ready   18m
               ├─ClusterRole/dsg-cluster-roles                    -              18m
               ├─ClusterRole/odh-dashboard                        -              18m
               ├─ClusterRoleBinding/odh-dashboard                 -              18m
               ├─ClusterRoleBinding/odh-dashboard-auth-delegator  -              18m
               ├─ClusterRoleBinding/odh-dashboard-monitoring      -              18m
opendatahub    ├─ConfigMap/odh-dashboard-params                   -              18m
               ├─ConsoleLink/odhlink                              -              18m
opendatahub    ├─Deployment/odh-dashboard                         -              18m
opendatahub    │ └─ReplicaSet/odh-dashboard-d8999cddc             -              18m
opendatahub    │   ├─Pod/odh-dashboard-d8999cddc-pnld8            True           18m
opendatahub    │   └─Pod/odh-dashboard-d8999cddc-q9g6d            True           12m
opendatahub    ├─OdhApplication/jupyter                           -              18m
opendatahub    ├─OdhDocument/jupyter-install-python-packages      -              18m
opendatahub    ├─OdhDocument/jupyter-update-server-settings       -              18m
opendatahub    ├─OdhDocument/jupyter-use-s3-bucket-data           -              18m
opendatahub    ├─OdhDocument/jupyter-view-installed-packages      -              18m
opendatahub    ├─OdhQuickStart/create-jupyter-notebook            -              18m
opendatahub    ├─OdhQuickStart/deploy-python-model                -              18m
opendatahub    ├─Role/fetch-accelerators-role                     -              18m
opendatahub    ├─Role/odh-dashboard                               -              18m
opendatahub    ├─Role/servingruntimes-config-updater              -              18m
opendatahub    ├─RoleBinding/accelerators                         -              18m
opendatahub    ├─RoleBinding/builds-and-images                    -              18m
opendatahub    ├─RoleBinding/cluster-image-pullers                -              18m
opendatahub    ├─RoleBinding/odh-dashboard                        -              18m
opendatahub    ├─RoleBinding/servingruntimes-config-updater       -              18m
opendatahub    ├─Route/odh-dashboard                              -              18m
opendatahub    ├─Secret/dashboard-oauth-client                    -              18m
opendatahub    │ └─Secret/dashboard-oauth-client-generated        -              18m
opendatahub    ├─Secret/dashboard-oauth-config                    -              18m
opendatahub    │ └─Secret/dashboard-oauth-config-generated        -              18m
opendatahub    ├─Service/odh-dashboard                            -              18m
opendatahub    │ ├─EndpointSlice/odh-dashboard-jhnsz              -              18m
opendatahub    │ └─Secret/dashboard-proxy-tls                     -              18m
opendatahub    └─ServiceAccount/odh-dashboard                     -              18m
opendatahub      └─Secret/odh-dashboard-dockercfg-fxjdn           -              18m

@lburgazzoli lburgazzoli force-pushed the kustomize_pipeline branch 4 times, most recently from 627326d to d90ce1f Compare October 17, 2024 15:29
@VaishnaviHire VaishnaviHire force-pushed the initialize_api branch 2 times, most recently from ecd060e to 59edbbf Compare October 17, 2024 21:24
@lburgazzoli
Copy link
Author

Closing this, I'll create some proper PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants