implement rust custom data renderer

[rbran]

No description provided.

[emesare]

Would like to see some tests for this, some of it was started here but still incomplete

ddad753

[rbran]

Would like to see some tests for this, some of it was started here but still incomplete

ddad753

That's the data_notification, not the data_renderer.

[emesare]

Would like to see some tests for this, some of it was started here but still incomplete
ddad753

That's the data_notification, not the data_renderer.

🤦 Thanks, something felt off when I sent that comment, disregard!

[lukbukkit]

Just for future reference, this PR addresses #6485 if I'm not mistaken.

I would profit from this API for my current project as I assume it offers performance benefits compared to its Python counterpart (#3082). Is there anything I can contribute to complete this PR, e.g. implement the missing tests?

[rbran]

Just for future reference, this PR addresses #6485 if I'm not mistaken.

I would profit from this API for my current project as I assume it offers performance benefits compared to its Python counterpart (#3082). Is there anything I can contribute to complete this PR, e.g. implement the missing tests?

This PR is missing the tests, plus I didn't finish this PR because I felt that I didn't get exactly how the API is supposed to work.

[rbran]

I was trying to write the API first by imagining how the user would like to use the API, then writing it in the most "zero cost abstraction" way possible.

But I couldn't get exactly how the user would want to use it API, I just ended up writing wrappers around the the C functions.

Maybe because you need to use this, you are in a much better position for writing it.

[lukbukkit]

Thanks for getting started with the PR. I think your approach of "just" writing a wrapper for C functions is totally valid. I found the API pretty intuitively to use as it's similar to its Python / C++ counterparts which have some documentation.

In my initial experiments, BinaryNinja crashed when using the API's Rust implementation due to the CoreDataRenderer being freed directly after being registered as there are no more references pointing to it, see data_renderer.rs#140.

I've remodeled the internal implementation after the CoreTypePrinter and now it works pretty reliably. You can see my changes in lukbukkit@24702e8. When I have some spare time, I'll try to finish the PR. Should I open a new PR once my changes are ready? Creating a lot of tests might prove a bit difficult because my license doesn't support running headlessly, but I'll see what I can do about it.

[rbran]

Should I open a new PR once my changes are ready?

Yes, Just remember to mark this PR, so it can be closed.

Creating a lot of tests might prove a bit difficult because my license doesn't support running headlessly, but I'll see what I can do about it.

It don't need to include many tests, just to prove that the implementation works.