Skip to content

Add layout attribute POC #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reeganviljoen
Copy link
Collaborator

@reeganviljoen reeganviljoen commented Mar 19, 2025

closses #2173

What are you trying to accomplish?

As per #2173 this adds a layout attribute, the main difference is that this monkey patches rails's render_in instead of making use of an upstream addition, this is supposed to act as a POC to strat the discusion about how the api looks like and top start next steps to get this done

Anything you want to highlight for special attention from reviewers?

This is not to be merged in its current state but to start the discusion for the api's implementation in view component and rails and how to achieve this

@reeganviljoen
Copy link
Collaborator Author

@joelhawksley I haven't done anything in a while and this POC was easy enough to setup to get my feet wet again, please have a look when you can

@joelhawksley joelhawksley marked this pull request as draft March 19, 2025 17:43
@joelhawksley
Copy link
Member

Marking as draft as this is not meant to be merged ❤️

@reeganviljoen
Copy link
Collaborator Author

thank you @joelhawksley
please feel free to add some feedback, before I submit a pull request to rails
cc @boardfish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants