Check if phases are not identical and if the sound speeds are real #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because the field value can be zero (and is an array)
…01, hydrotemplate.vMin)
jorindevandevis
requested review from
niemilau and
joonashir
and removed request for
niemilau
main check thermo into SMlightHiggs
Smlight higgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three quick checks in WallGoManager:
If these checks fail, nothing will work, so the program should stop.
I also changed the velocity in the determination of TminTemplate from 0.01 to min(0.01, hydrotemplate.vMin), because if the PT is really strong, no solution can be found for vw = 0.01.
If this PR is approved, I would recommend merging it into any branches where models are being implemented. If those implementations fail, this PR could help figure out the cause of the failure.