Fix for matrix element generation #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…streaming internally
jorindevandevis
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very short PR that includes updates to the
src/WallGo/mathematicaHelpers.pyfile to improve code readability and functionality. The most important changes include adding a module-level docstring, refactoring the banner printing, and updating the subprocess command.Improvements to code readability:
src/WallGo/mathematicaHelpers.py: Added a module-level docstring to describe the purpose of the file and where to place common functions.Refactoring and functionality updates:
src/WallGo/mathematicaHelpers.py: Refactored the banner printing ingenerateMatrixElementsViaSubprocessto split it intoupperBannerandlowerBannerfor better readability.src/WallGo/mathematicaHelpers.py: Updated thecommandlist ingenerateMatrixElementsViaSubprocessto include--outputFilefor clarity and correctness.