Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update ReadTheDocs #317

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Docs update ReadTheDocs #317

merged 18 commits into from
Oct 23, 2024

Conversation

og113
Copy link
Collaborator

@og113 og113 commented Oct 22, 2024

Various updates to the docs, assuming we are going with ReadTheDocs.

  • Moved to fully automatic API documentation (using sphinx.ext.autosummary), so that the docs are comprehensive and easier to maintain
  • Added missing base example
  • Updated installation
  • Updated README.md with ReadTheDocs link
  • Removed highlighting in LICENSE
  • Updated code lines in First Example

Note that you can compare the docs made on this PR to those on main by comparing the following links:

@og113 og113 requested a review from jorindevandevis October 22, 2024 22:28
@og113 og113 added the documentation Improvements or additions to documentation label Oct 22, 2024
@jorindevandevis
Copy link
Collaborator

Thanks Oli, this looks very good.

Just to be sure: the docs associated to this PR are in here, right https://wallgo.readthedocs.io/en/docsupdatebeta/ ? And if you merge this into main, they will also be here: https://wallgo.readthedocs.io/en/latest/ ?

When I go to the section Collected Examples, I read "[...] we have written an example base code, which the specific models utilise." and the description of the PR also writes that you added the base example, but I can not find it in the documentation.

@og113
Copy link
Collaborator Author

og113 commented Oct 23, 2024

Thanks Oli, this looks very good.

Just to be sure: the docs associated to this PR are in here, right https://wallgo.readthedocs.io/en/docsupdatebeta/ ? And if you merge this into main, they will also be here: https://wallgo.readthedocs.io/en/latest/ ?

When I go to the section Collected Examples, I read "[...] we have written an example base code, which the specific models utilise." and the description of the PR also writes that you added the base example, but I can not find it in the documentation.

Yes, your understanding of the merging process and associated docs pages is correct.

I have fixed the missing Collected Examples page, thanks for that. It was macOS being case-blind for filenames again, so that despite a case error the docs building worked locally but didn't work on the ReadTheDocs, which probably runs Linux and hence is not case-blind.

@og113
Copy link
Collaborator Author

og113 commented Oct 23, 2024

Also, note that ReadTheDocs doesn't make docs for all the branches. I had to ask it specially to make the docs for the branch of this PR, and after the PR is merged I will remove https://wallgo.readthedocs.io/en/docsupdatebeta/.

Copy link
Collaborator

@jorindevandevis jorindevandevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good, thanks!

@jorindevandevis
Copy link
Collaborator

Maybe we have to wait with merging until the deleteSimpleModel branch is approved?

main()


# class YukawaModelExample(WallGoExampleBase):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should obviously be deleted, not just commented out. I will update it on my branch

@og113
Copy link
Collaborator Author

og113 commented Oct 23, 2024

Maybe we have to wait with merging until the deleteSimpleModel branch is approved?

We don't have the simple model in the list of examples, just the Yukawa model, so I think it should be okay.

@og113 og113 merged commit c195c11 into main Oct 23, 2024
3 checks passed
@og113 og113 deleted the DocsUpdateBeta branch October 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants