Fixing broken PyPI publishing #350
Conversation
og113
requested review from
pschicho,
joonashir,
niemilau,
jorindevandevis and
benoitlaurent96
| git status | ||
| git log -n 2 | ||
| git diff | ||
|
|
There was a problem hiding this comment.
What's this for? I'm imagining the intention may be to abort if there are local changes, but I don't think this even does that?
There was a problem hiding this comment.
Yes, it just prints things for debugging. Any local changes change the tag and break a release on PyPI. I have found it handy to fix the current issue, and don't see much reason to drop it, as if there is a failure in future we will have more info, and it doesn't exactly take any time to execute.
| - name: Install WallGo Python package | ||
| run: | | ||
| pip uninstall WallGo | ||
| pip install . --upgrade -v |
There was a problem hiding this comment.
Is the uninstall necessary? I'm under the impression that github runners always start with a fresh virtual environment
There was a problem hiding this comment.
Yes, it is. Again, just for debugging purposes. I could remove it another day, but for now I think let's proceed, as we approach the submission deadline.
The issue was that an .hdf5 file was changed by the checkout process (for some reason?) and this meant the tag was out of date. Fixed by adding data in
tests/TestData/N*/*.hdf5to git-lfs.