Skip to content

Response handler for dynamic requests (POC) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

teameh
Copy link

@teameh teameh commented Oct 4, 2024

I'm using Mocker as mock backend for our app to be able to develop the app in "demo mode" as long as other developers are still working on the backend.

This sometimes requires a more dynamic response to be returned from the mocks based on the request body or previous requests. I considered creating something from scratch based off Mocker, but instead I've added a simple responseHandler option to my own fork to facilitate this.

It works great and just using my own fork works fine, but I can imagine that this could be valuable for other developers as well. Here's a POC branch that demonstrates this. If you think this is something that would benefit Mocker, I could draft up a real PR with a nicer implementation if you like.

@teameh teameh requested a review from a team October 4, 2024 08:21
Copy link

github-actions bot commented Nov 4, 2024

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 4, 2024
@teameh
Copy link
Author

teameh commented Nov 4, 2024

ping @AvdLee perhaps?

@github-actions github-actions bot removed the Stale label Nov 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 5, 2024
@teameh
Copy link
Author

teameh commented Dec 5, 2024

ping @kairadiagne perhaps?

@github-actions github-actions bot removed the Stale label Dec 6, 2024
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 11, 2025
@teameh
Copy link
Author

teameh commented Jan 11, 2025

..

@github-actions github-actions bot removed the Stale label Jan 12, 2025
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 12, 2025
@teameh
Copy link
Author

teameh commented Feb 12, 2025

.

@github-actions github-actions bot removed the Stale label Feb 13, 2025
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 15, 2025
@teameh
Copy link
Author

teameh commented Mar 15, 2025

..

@github-actions github-actions bot removed the Stale label Mar 16, 2025
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 16, 2025
Copy link

@rubensmachion rubensmachion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@teameh
Copy link
Author

teameh commented Apr 27, 2025

Here's a POC branch that demonstrates this. If you think this is something that would benefit Mocker, I could draft up a real PR with a nicer implementation if you like.

It still needs some polishing. Would you review and approve and merge the changes if I do this work?

@rubensmachion
Copy link

Hi @teameh, it looks good to me and I’ve just approved the PR, but I believe we need more approvals. I’m not a member of the WeTransfer team, but I use Mocker a lot to write unit tests.

@github-actions github-actions bot removed the Stale label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants