-
Notifications
You must be signed in to change notification settings - Fork 21
Feat/v10 upgrade #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/v10 upgrade #128
Conversation
src/Web3Auth.ts
Outdated
this.options.authConnectionConfig ?? [], | ||
"authConnectionId" | ||
); | ||
this.options.mfaSettings = merge(clonedeep(this.projectConfig.mfaSettings), this.options.mfaSettings); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge other settings as well here - like sessionTime, userDataInIdToken, mfa settings etc.
Can refer to no-modal sdk as well to check how the config from the user and config from the apis are merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arch1995 i updated other fields
for sessionTime and includeUserDataInToken already has default value in constructor
if (!options.sessionTime) options.sessionTime = 86400;
if (typeof options.enableLogging === "undefined") options.enableLogging = false;
if (options.enableLogging) {
log.setLevel("debug");
} else {
log.setLevel("ERROR");
}
if (typeof options.includeUserDataInToken === "boolean") options.includeUserDataInToken = true;
Motivation and Context
v10 upgrade
Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-4992
Description
Use auth service v10, WS v5
Update init options
Handle v2 project config
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: