Skip to content

Conversation

tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Aug 22, 2025

Motivation and Context

Handle both pnp and sfa

Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-4991?atlOrigin=eyJpIjoiZGE1ZGNhNzYzMzExNGMwM2I3ZDk3ODAzNTZjODViODUiLCJwIjoiaiJ9

Description

change login method to connectTo method
use sfa if loginParams has idToken property
otherwise use pnp

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant