Skip to content

TEMP DRAFT: Ximinez/vault test #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: ximinez/Bronek/vault
Choose a base branch
from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Apr 9, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez ximinez changed the base branch from develop to ximinez/Bronek/vault April 9, 2025 22:04
@ximinez ximinez force-pushed the ximinez/vault-test branch from 1e82440 to 01b152d Compare April 9, 2025 22:41
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (5fea68e) to head (d6a2ce2).

Files with missing lines Patch % Lines
src/xrpld/app/main/Main.cpp 55.6% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           ximinez/Bronek/vault   #5394   +/-   ##
====================================================
  Coverage                  78.2%   78.2%           
====================================================
  Files                       808     808           
  Lines                     69603   69612    +9     
  Branches                   8311    8310    -1     
====================================================
+ Hits                      54451   54463   +12     
+ Misses                    15152   15149    -3     
Files with missing lines Coverage Δ
src/xrpld/app/main/Main.cpp 77.9% <55.6%> (-1.0%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ximinez ximinez force-pushed the ximinez/vault-test branch 5 times, most recently from d6a2ce2 to 84b4e2a Compare April 11, 2025 23:34
@ximinez ximinez added DraftRunCI Normally CI does not run on draft PRs. This opts in. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Apr 12, 2025
@ximinez ximinez force-pushed the ximinez/vault-test branch from 84b4e2a to 98bafb2 Compare April 14, 2025 19:49
ximinez added a commit that referenced this pull request Apr 15, 2025
- Takes a page from #5394, which may turn out to be useful!
@ximinez ximinez force-pushed the ximinez/vault-test branch from 98bafb2 to be219fe Compare April 24, 2025 14:51
@ximinez ximinez force-pushed the ximinez/Bronek/vault branch from 9ab36dd to fb2eb35 Compare April 24, 2025 16:01
@ximinez ximinez force-pushed the ximinez/vault-test branch 2 times, most recently from 8481ed6 to 7937823 Compare April 28, 2025 18:45
@ximinez ximinez force-pushed the ximinez/Bronek/vault branch from 40d80b8 to 01cc089 Compare April 29, 2025 16:23
@ximinez ximinez force-pushed the ximinez/vault-test branch from 7937823 to de0b4e1 Compare April 30, 2025 18:47
@ximinez ximinez force-pushed the ximinez/vault-test branch from de0b4e1 to b17e50d Compare May 7, 2025 18:52
@ximinez ximinez force-pushed the ximinez/vault-test branch from b17e50d to 4da5c72 Compare May 15, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant