Fix item tooltips not getting parsed a second time

Localisation got hands. Never bugfix on a sunday 1am. My bad. :(
Xerren09 · Jan 19, 2025 · 7bb1526 · 7bb1526
1 parent 830679c
commit 7bb1526
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/Patches/LocalisationPatches.cs b/Patches/LocalisationPatches.cs
@@ -57,8 +57,9 @@ private static bool GetTootipData(Item __instance, ref IEnumerable<IHaveUIData>
                 string parsedTip = ParseTip(__instance, tip, out IMKbPromptProvider provider, out List<ControllerGlyphs.GlyphType> glyphType);
                 ret.Add(new ItemKeyTooltip(parsedTip, provider, glyphType));
             }
+            // FIX: don't write the new array to the item, assuming it to be set via SetDefaultTooltips
             // Set localised tooltips back as a failsafe
-            __instance.Tooltips = ret;
+            //__instance.Tooltips = ret;
             __result = ret;
             return false;
         }

diff --git a/ShopApiPlugin.cs b/ShopApiPlugin.cs
@@ -17,7 +17,7 @@ public class ShopApiPlugin
     {
         public const string MOD_GUID = "xerren.cwshopapi";
         public const string MOD_NAME = "ShopAPI";
-        public const string MOD_VER = "1.0.1";
+        public const string MOD_VER = "1.0.2";
 
 #if STEAM
         static ShopApiPlugin()

diff --git a/ShopLocalisation.cs b/ShopLocalisation.cs
@@ -1,5 +1,4 @@
-using ShopAPI.Patches;
-using UnityEngine;
+using UnityEngine;
 using UnityEngine.Localization.Settings;
 
 namespace ContentWarningShop.Localisation

diff --git a/publish/thunderstore/CHANGELOG.md b/publish/thunderstore/CHANGELOG.md
@@ -3,6 +3,9 @@
 All notable changes will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.2
+- Fix tooltips not being parsed correctly when using the fallback
+
 ## 1.0.1
 - Fix `GetTootipData` patch exception when null tooltips are set on the Item, and no localised strings were provided.
   - This is unity's fault. Tooltips should be serialised correctly on Item resources, but they aren't loaded, so the count is correct but the text is null.

diff --git a/publish/thunderstore/manifest.json b/publish/thunderstore/manifest.json
@@ -1,6 +1,6 @@
 {
     "name": "ShopAPI",
-    "version_number": "1.0.1",
+    "version_number": "1.0.2",
     "website_url": "https://github.com/Xerren09/ContentWarningShopAPI",
     "description": "Exposes an easy-to-use API to add custom items to the in-game shop.",
     "dependencies": [