Add prefix #16
Open
Add prefix #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like what you've described above! Let me take some time to review your attached pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-Poption to add a prefix before all module paths.Currently, if you generate multiple different instances of the (i)fft with different parameters, tools will complain that the modules all have the same name. This commit adds an optional prefix which is added before all module names and filenames so that they can be unique per configuration.
In my case, I have a project where I am using a regular FFT and an inverse FFT in the same hierarchy. With this change, I can prefix all of the fft modules with
rx, and all of the ifft modules withtx.If no option is supplied, then prefix is an empty string and the result is the same as before, otherwise the prefix is added with an underscore.