-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Signet option #149
Adding Signet option #149
Conversation
Added Signet option
Adding signet config option to network
Signet support would be welcome as it is preferred over testnet3. |
mempool.space thinks signet has 35 lightning nodes while testnet shows 470 and mainnet has 15,487 I'm pretty sure signet would require a patch to min_node_to_process see ad49445 I suspect this parameter should be different for each network |
I added a PR which sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK make sense, if you help to mantaining it.
Also signet is a little bit strange because can be more signet network.
clboss keep a list of nodes (aka seeds) to start connecting with, so this is PR is missing to add it. In addition, we should make sure that this peer should be living enough.
An alternative approach is specify at least one seed as plugin option, this could help with signet, but not sure how the clboss metrics will react with a single node
Ended up reimplementing this myself before I knew this PR existed #207 xD Let's just merge this, it works great for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with mutinynet
Looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late to the discussion, but I think this PR is missing a list of seed nodes for signet. Or am I missing something?
Additionally, we may want to provide a seed list via a command line option, considering it is unclear how many signet network there are.
Ah I forgot about seed nodes. You can just connect to the faucet node on mutinynet, you can find the URI on https://faucet.mutinynet.com |
There is another PR for updating the mainnet seed nodes. The CLBOSS support isn't very good on any network. I generally make a few manual seed connections and bootstrap gossip that way ... Maybe we should make a DNS based thing so at least the nodes aren't compiled in ... |
to clarify, I only make initial gossip connections manually, everything else works automatically |
This is referencing the issue #148 adds Signet support by adding the keywords.
It seems to work but I am not sure how to guarantee quality, if there are tests then I would be happy to run them.
As far as I can tell, the only thing missing is being able to test boltz integration
clboss/Boss/Mod/BoltzSwapper/Main.cpp
Line 28 in 3379983