change default value of --process to (number of CPUs)-1 #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsuchy
force-pushed
the
2980
branch
2 times, most recently
from
cc8c78b to
4ded913
Compare
|
I believe the tests failures on MacOS is not relevant to this code. |
AyanSinhaMahapatra
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
@xsuchy Thanks++ for the PR.
Overall this sounds like a nice idea, to increase the number of CPUs by default.
It seems like we have an agreement to have this at n-1 from #2980, and this sounds mostly fine to me, although n-2 could have been safer when users might have multiple other things open/in use if they are running scancode in their personal computers. But everywhere else this sounds great, and folks can always reduce the default CPU if it creates problems.
Not sure about the test failures, could you merge latest develop just to be sure?
@pombredanne please review this too.
Related: aboutcode-org#2980 Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
|
Rebased on top of develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2980
Tasks
Run tests locally to check for errors.
Test suite fails to run for me, but the script run correctly.