Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule for eupl license #4204

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Add new rule for eupl license #4204

merged 1 commit into from
Apr 13, 2025

Conversation

alok1304
Copy link
Contributor

Fixes #4203

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com

@alok1304 alok1304 force-pushed the new_rule_for_eupl branch 2 times, most recently from 7a48fca to 9c4fb1a Compare March 19, 2025 16:40
@alok1304
Copy link
Contributor Author

these failing test cases are passed on my system.

AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Apr 4, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @alok1304, see comment for adding required phrases to rules. Looks good otherwise.

@alok1304 alok1304 force-pushed the new_rule_for_eupl branch 2 times, most recently from 1768fc4 to 248ad5c Compare April 4, 2025 19:53
@alok1304
add new rule for eupl license
746fb08 
Reference: aboutcode-org#4203
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
@alok1304 alok1304 force-pushed the new_rule_for_eupl branch from 248ad5c to 746fb08 Compare April 11, 2025 18:14
pombredanne
pombredanne approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking good!

@pombredanne pombredanne merged commit f94330e into aboutcode-org:develop Apr 13, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@AyanSinhaMahapatra AyanSinhaMahapatra Awaiting requested review from AyanSinhaMahapatra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new rule for eupl-1.0 , eupl-1.1 and eupl-1.2 licenses
3 participants
@alok1304 @pombredanne @AyanSinhaMahapatra