-
-
Notifications
You must be signed in to change notification settings - Fork 111
Add left-pane file tree view and related templates #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add left-pane file tree view and related templates #1704
Conversation
0ffbe25
to
6172941
Compare
Hey @AyanSinhaMahapatra @tdruez can I have a review of this pr |
03842ca
to
7b8ba33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayushkdev Off to a good start, see my various comments for improvements.
The naming convention needs consistency:
resource_tree
, file_tree
, file_tree_panel
, file-tree
, CodebaseResourceTree
, codebase_tree
, Resource Tree
Let's use CodebaseResourceTree
and resource_tree
everywhere rather than "file...".
You can start the implementation of the left and right panels rendering.
b1f8a7f
to
3d1c4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments for refinements.
Once done with those, you can continue the implementation of
Clicking the folder name is intended to display the list of that folder’s children in the right pane. (Not yet implemented)
Clicking on a file is intended to show that individual file’s details or metadata in the right pane. (Not yet implemented)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayushkdev The current code is fine, you can implement the missing parts before the next review round.
e20208a
to
154d1a6
Compare
@aayushkdev What's the status on the right panel functionalities? |
I've completed the basic implementation of the right panel functionality and will create a PR soon. I was waiting for the previous PRs to be approved and merged first, so the Git history remains clean. This way, I won't need to temporarily include parts of the previous code just to make things work, only to remove them later before merging. |
The commits are squashed as a single one when the PR is merged. You do not have to worry about the git history. |
okayy sure I
ah okayy I was thinking about seperate prs for right and left pane but yeah that makes much more sense to do it in a single commit I will do a commit with the right pane soon |
@aayushkdev #1691 and #1776 are now merged. You can merge main in this branch as well. |
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
154d1a6
to
633e5df
Compare
Hey @tdruez I have pushed the right panel but some tests still fail even though all pass in my system I think it might be a issue with the CI/CD as the tests that fail are unrelated to my code Screencast_20250728_224440.webmThings that are currently left to do
|
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
@aayushkdev Could you merge the latest |
For the past week I have been testing out different ways of filtering/searching and I will be making a commit for the filtering functionality soon
|
@aayushkdev you haven't reported progress in a while, anything blocking you? |
Currently I have my midsems exams going on thats why havent been that active. I have added filtering support in my latest commit. but the search and filtering are taking time as I am trying to use the existing search/filtering components for adding these features and the existing component are not designed for htmx (display data without page reloads) so I am trying to adapt these components to support htmx for the codebase_tree view and make sure it still supports the other views which use these components. |
Ok, I'm suggesting that instead of doing too much here, we focus on having a clean, simple first PR that can be merged and used, and we add the search/filtering an more features in other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the searching and filtering logic and let's have something that can be merged asap ;)
scanpipe/filters.py
Outdated
("_EMPTY_", "None"), | ||
("_ANY_", "Any"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use the hardcoded values but the variable instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to the filters I'll keep this in mind in my next pr
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
f9d6325
to
e665feb
Compare
I think this branch should be ready to merge, it has the basic functionality of the resource tree. |
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
fix #1682
tree.webm
Summary/Goals of this change
The goal of this PR is to introduce a collapsible file tree panel in the left pane of the project resource view. This view allows users to explore the project's CodebaseResource in a more user friendly way.
Clicking the chevron next to a folder toggles a dropdown view of its immediate children in the tree (left pane).
Clicking the folder name is intended to display the list of that folder’s children in the right pane. (Not yet implemented)
Clicking on a file is intended to show that individual file’s details or metadata in the right pane. (Not yet implemented)
Note: This pr depends on the
parent_path
field introduced in #1687. To ensure tests pass and the functionality works, I’ve temporarily duplicated the necessary parts of that change here. These changes will be removed once that pr is merged.