SMQ-2706 - Add domain route to message topic #2765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
+ Coverage 27.54% 30.56% +3.02%
==========================================
Files 351 207 -144
Lines 55347 37371 -17976
==========================================
- Hits 15243 11424 -3819
+ Misses 39346 25328 -14018
+ Partials 758 619 -139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arvindh123
reviewed
Mar 20, 2025
channels/private/service.go
Outdated
Comment on lines
42
to
47
| d, err := svc.domains.RetrieveEntity(ctx, req.DomainID) | ||
| if err != nil { | ||
| return errors.Wrap(svcerr.ErrAuthorization, err) | ||
| } | ||
| if d.Status != dom.EnabledStatus { | ||
| return errors.Wrap(svcerr.ErrAuthorization, errDisabledDomain) | ||
| } |
There was a problem hiding this comment.
If req.ClientType is policies.UserType, then we might need to check user is present in domain or not.
I'm not sure about this , but i need to test this case.
Steps to replicate :
- We need to add member to domain role
- Add access to channel
- Remove member from domain role
- then test reading value of message via reader.
On removal of member from domain role and if member is not removed from other entities and removed only from domains, then even after removal of member will still have access to channels.
User removal PR will solve this case.
There was a problem hiding this comment.
I have created ticket here #2767
arvindh123
previously approved these changes
Mar 20, 2025
felixgateru
force-pushed
the
smq2706-domain
branch
2 times, most recently
from
81565c6 to
45d192d
Compare
felixgateru
force-pushed
the
smq2706-domain
branch
3 times, most recently
from
a5d6ec4 to
4160a8f
Compare
felixgateru
changed the title
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
felixgateru
force-pushed
the
smq2706-domain
branch
from
4160a8f to
ff19935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds domain route to message topic.
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been updated.
Did you document any new/modified feature?
Yes, in code documentation has been updated.
Notes
None