Skip to content

[media] Translate media module #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

[media] Translate media module #9952

wants to merge 26 commits into from

Conversation

SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module media to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to media tab to see translated web page.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: examiner PR or issue related to examiner module Module: genomic_browser PR or issue related to genomic_browser module Module: imaging_browser PR or issue related to imaging_browser module Module: media PR or issue related to media module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module labels Aug 11, 2025
@SKADE2303 SKADE2303 removed Language: PHP PR or issue that update PHP code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: examiner PR or issue related to examiner module labels Aug 11, 2025
racostas
racostas reviewed Sep 2, 2025
View reviewed changes
Makefile Outdated
@@ -60,7 +60,7 @@ testdata:
locales:
msgfmt -o locale/ja/LC_MESSAGES/loris.mo locale/ja/LC_MESSAGES/loris.po
npx i18next-conv -l ja -s locale/ja/LC_MESSAGES/loris.po -t locale/ja/LC_MESSAGES/loris.json
msgfmt -o locale/hi/LC_MESSAGES/loris.mo locale/hi/LC_MESSAGES/loris.po
msgfmt -o locale/hi/LC_MESSAGES/loris.mo locale/ja/LC_MESSAGES/loris.po
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally changed or it's a typo ? From previous hi to ja

Suggested change
msgfmt -o locale/hi/LC_MESSAGES/loris.mo locale/ja/LC_MESSAGES/loris.po
msgfmt -o locale/hi/LC_MESSAGES/loris.mo locale/hi/LC_MESSAGES/loris.po

racostas
racostas requested changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments. Thanks.

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 2, 2025
Dave MacFarlane and others added 26 commits September 5, 2025 09:35
[candidate_list] Translate candidate_list module
e825915 
This translates the candidate list module as an example of how
to do localization of a loris module that is written in React
with class based components.
Changes to add Hindi
d6f32d7
[candidate_list] Translate candidate_list module
e436c0f 
This translates the candidate list module as an example of how
to do localization of a loris module that is written in React
with class based components.
Translate strings from data table / filters so that candidate list mo…
24fdf2f 
…dule is fully translated
Added translated strings
cd8ba4d
Revert parts of commit a049917: remove extra Hindi files and changes
8ef6b54
Updated Makefile
7630711
Update Makefile
a7fdd0a
Translate strings from data table / filters so that candidate list mo…
8ef30e2 
…dule is fully translated
Revert "Translate strings from data table / filters so that candidate…
2bed3f4 
… list module is fully translated"

This reverts commit b467ce6.
Fix eslint
50fc28a
Translate strings from data table / filters so that candidate list mo…
0ecfc82 
…dule is fully translated
Add withTranslation for conflict_resolver
1df9e02 
Also fix syntax of export to fix tests.
change DataTable.js
e6b33a4
lint issues
d4329db
lint
07f708c
remove additional .po file
c76d9a0
Add translations
292c0f5
lint
52091dd
Add translations
05c4776
lint
2efd9d0
Remove candidate list, JSON files, and jsx changes from PR
7f56449
Revert unwanted changes (loris.po, candidate_list.po, dataDictIndex.j…
660d024 
…s, etc.)
update Makefile
68f47f7
Add Makefile
ccead9f
fixes
65661b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racostas racostas racostas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@racostas racostas

Labels
Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: candidate_list PR or issue related to candidate_list module Module: datadict PR or issue related to (old) datadict module Module: media PR or issue related to media module Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SKADE2303 @racostas