[document_repository] Translate document repository #9954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: PHP
SKADE2303
removed
Language: PHP
SKADE2303
added
Event: GSOC
added 2 commits
August 11, 2025 09:57
SKADE2303
force-pushed
the
TranslateDocumentRepository
branch
from
1365ea0 to
dc2ff91
Compare
driusan
reviewed
Aug 25, 2025
| // Data loading error | ||
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', | ||
| {ns: 'document_repository'})}</h3>; |
There was a problem hiding this comment.
I think this is in the loris namespace?
driusan
reviewed
Aug 25, 2025
| // If error occurs, return a message. | ||
| // XXX: Replace this with a UI component for 500 errors. | ||
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', | ||
| {ns: 'document_repository'})}</h3>; |
There was a problem hiding this comment.
wrong namespace here too?
driusan
reviewed
Aug 25, 2025
| // Data loading error | ||
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', | ||
| {ns: 'document_repository'})}</h3>; |
driusan
reviewed
Aug 25, 2025
| @@ -107,7 +112,7 @@ class DocEditForm extends React.Component { | |||
| /> | |||
| <SelectElement | |||
| name="forSite" | |||
| label="Site" | |||
| label={t('Site', {ns: 'document_repository'})} | |||
driusan
reviewed
Aug 25, 2025
| @@ -116,35 +121,36 @@ class DocEditForm extends React.Component { | |||
| /> | |||
| <SelectElement | |||
| name="instrument" | |||
| label="Instrument" | |||
| label={t('Instrument', {ns: 'document_repository'})} | |||
There was a problem hiding this comment.
not sure if it currently exists in the loris namespace but "Instrument" is a common loris term that should be in that namespace.
driusan
reviewed
Aug 25, 2025
| options={this.state.data.instruments} | ||
| onUserInput={this.setFormData} | ||
| value={this.state.docData.instrument} | ||
| /> | ||
| <TextboxElement | ||
| name="pscid" | ||
| label="PSCID" | ||
| label={t('PSCID', {ns: 'document_repository'})} |
driusan
reviewed
Aug 25, 2025
| onUserInput={this.setFormData} | ||
| disable = {true} | ||
| value={this.state.docData.pscid} | ||
| /> | ||
| <TextboxElement | ||
| name="visitLabel" | ||
| label="Visit Label" | ||
| label={t('Visit Label', {ns: 'document_repository'})} |
driusan
reviewed
Aug 25, 2025
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', | ||
| {ns: 'document_repository'})}</h3>; |
driusan
reviewed
Aug 25, 2025
| options={this.state.data.fieldOptions.fileCategories} | ||
| onUserInput={this.setFormData} | ||
| required={true} | ||
| value={this.state.formData.category} | ||
| /> | ||
| <SearchableDropdown | ||
| name="forSite" | ||
| label="Site" | ||
| placeHolder="Search for site" | ||
| label={t('Site', {ns: 'document_repository'})} |
driusan
reviewed
Aug 25, 2025
| @@ -124,40 +129,41 @@ class DocUploadForm extends Component { | |||
| /> | |||
| <SelectElement | |||
| name="instrument" | |||
| label="Instrument" | |||
| label={t('Instrument', {ns: 'document_repository'})} | |||
driusan
reviewed
Aug 25, 2025
| options={this.state.data.fieldOptions.instruments} | ||
| onUserInput={this.setFormData} | ||
| value={this.state.formData.instrument} | ||
| /> | ||
| <TextboxElement | ||
| name="pscid" | ||
| label="PSCID" | ||
| label={t('PSCID', {ns: 'document_repository'})} |
driusan
reviewed
Aug 25, 2025
| onUserInput={this.setFormData} | ||
| value={this.state.formData.pscid} | ||
| /> | ||
| <TextboxElement | ||
| name="visitLabel" | ||
| label="Visit Label" | ||
| label={t('Visit Label', {ns: 'document_repository'})} |
racostas
added
the
State: Needs work
|
Hi @SKADE2303, please address @driusan comments, This are the same issues we disused in #9941. Correct me if I'm wrong but I think to remember we also had a meeting about it. This namespace issue have to be addressed in most of all PRs sent. Please take a careful look to each one again. Thank you. |
SKADE2303
added
State: Needs work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module document_repository to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)