Skip to content

Commit

Permalink
AudioDxe: Downgrade log level from DEBUG_WARN to DEBUG_INFO for EFI_A…
Browse files Browse the repository at this point in the history
…LREADY_STARTED
  • Loading branch information
mikebeaton committed Dec 29, 2024
1 parent 1eb545e commit 5a61796
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ OpenCore Changelog
- Removed `--` prefix from OpenNetworkBoot arguments (modify driver arguments if using this driver)
- Updated `Unload` option to unload drivers in reverse of the order in which they were loaded
- Fixed `MSR_IA32_TSC_ADJUST` access on unsupported CPUs (e.g. Virtualization.framework), thx @t0rr3sp3dr0
- Downgraded WARN log level to INFO for ALREADY_STARTED in AudioDxe (restores ability to include DEBUG_WARN in HaltLevel if required when using this driver)

#### v1.0.3
- Fixed support for `AMD_CPU_EXT_FAMILY_1AH`, thx @Shaneee
Expand Down
9 changes: 8 additions & 1 deletion Staging/AudioDxe/HdaController/HdaController.c
Original file line number Diff line number Diff line change
Expand Up @@ -1096,6 +1096,13 @@ HdaControllerDriverBindingStart (
OpenMode
);

if ( (OpenMode == EFI_OPEN_PROTOCOL_BY_DRIVER)
&& (Status == EFI_ALREADY_STARTED))
{
DEBUG ((DEBUG_INFO, "HDA: %a%a - %r\n", "Open PCI I/O protocol", "", Status));
return Status;
}

if (EFI_ERROR (Status)) {
if ( PcdGetBool (PcdAudioControllerTryProtocolGetMode)
&& (Status == EFI_ACCESS_DENIED)
Expand All @@ -1112,7 +1119,7 @@ HdaControllerDriverBindingStart (
continue;
}

DEBUG ((DEBUG_WARN, "HDA: Open PCI I/O protocol (try DisconnectHda quirk?) - %r\n", Status));
DEBUG ((DEBUG_WARN, "HDA: %a%a - %r\n", "Open PCI I/O protocol", " (try DisconnectHda quirk?)", Status));
return Status;
}
} while (EFI_ERROR (Status));
Expand Down

0 comments on commit 5a61796

Please sign in to comment.