Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Add support for 32-bit on 32-bit under GDB #493

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

mikebeaton
Copy link
Contributor

In addition to existing support for 32-bit on 64-bit

@mikebeaton mikebeaton requested a review from vit9696 October 26, 2023 07:33
@mikebeaton
Copy link
Contributor Author

mikebeaton commented Oct 26, 2023

@vit9696 If not for your comments by PM last night, I would have thought it was more or less obvious that the natural implementation would be that CPU_ARCH follows EFI_ARCH, but can be overridden. But I've implemented that CPU_ARCH is always X64 by default (regardless of EFI_ARCH), but can be overridden. Sounds like that may be what more users want to run, and has the (dubious?!) advantage of remaining compatible with how the script is currently called.

I've also changed from Ia32 to IA32 as the canonical arch name (matching changes elsewhere), but have added a small amount of code to keep compatibility with Ia32 value, for the same (dubious?) reason added support for IA32 (still normalised to Ia32 as the canonical and subdirectory name), since that matches the ARCH name passed in shell vars to EDK/OVMF/OC build scripts.

@mikebeaton mikebeaton marked this pull request as draft October 26, 2023 15:27
@mikebeaton
Copy link
Contributor Author

mikebeaton commented Oct 26, 2023

Apologies - directory names need updating for change from Ia32 to IA32 (and will prevent it working on case sensitive FS like Unix until changed) - will fix this eve.

In addition to existing support for 32-bit on 64-bit
@mikebeaton
Copy link
Contributor Author

mikebeaton commented Oct 26, 2023

Sorry, running commentary, I've switched back to Ia32 as the canonical name, but now allowing IA32 as well (normalised to Ia32 in the script), e.g. same as target arch spec for EDK and OC build scripts.

@mikebeaton mikebeaton marked this pull request as ready for review October 26, 2023 17:10
@mikebeaton
Copy link
Contributor Author

Checked working in Linux (gdb 32/32, gdb 32/64, lldb 64/64) and macOS (gdb 32/32, gdb 32/64, lldb 64/64).

@vit9696 vit9696 merged commit 4d2fed9 into acidanthera:master Oct 26, 2023
11 checks passed
@vit9696
Copy link
Contributor

vit9696 commented Oct 26, 2023

Looks good to me, merged, tyvm!

@mikebeaton mikebeaton deleted the gdb32 branch November 9, 2023 11:39
kokowski pushed a commit to kokowski/OpenCorePkg that referenced this pull request Nov 20, 2023
In addition to existing support for 32-bit on 64-bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants