-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: Test app add missing components #8779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build successful! 🎉 |
Did an audit, and here are the remaining components the test apps are missing:
These don't need to be added in this PR, just wanted to put them somewhere. |
Should be covered by the loading state of the cardview
Not an S2 component yet |
This reverts commit 3677ebf.
Build successful! 🎉 |
@@ -26,6 +26,7 @@ import { | |||
Menu, | |||
MenuItem, | |||
MenuTrigger, | |||
NotificationBadge, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this ones missing an ActionBar
import
Closes
Adds Calendar, RangeCalendar, DateField, TimeField, DatePicker, DateRangePicker, ActionBar, SelectBox, FullScreen Dialog, NotificationBadge
✅ Pull Request Checklist:
📝 Test Instructions:
Check verdaccio builds of the apps for date/time fields
See links here 62f1b39#comments
🧢 Your Project: