Skip to content

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Aug 27, 2025

Closes

Adds Calendar, RangeCalendar, DateField, TimeField, DatePicker, DateRangePicker, ActionBar, SelectBox, FullScreen Dialog, NotificationBadge

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check verdaccio builds of the apps for date/time fields
See links here 62f1b39#comments

🧢 Your Project:

@rspbot
Copy link

rspbot commented Aug 27, 2025

reidbarber
reidbarber previously approved these changes Aug 27, 2025
@reidbarber
Copy link
Member

reidbarber commented Aug 27, 2025

Did an audit, and here are the remaining components the test apps are missing:

  • ActionBar
  • AssetCard, ProductCard, UserCard
  • Autocomplete
  • ComboBoxSection, MenuSection, PickerSection
  • FileTrigger
  • FullscreenDialog
  • NotificationBadge
  • SelectBox, SelectBoxGroup
  • Skeleton
  • Toast (UNSTABLE_ToastContainer, UNSTABLE_ToastQueue)
  • TreeViewLoadMoreItem

These don't need to be added in this PR, just wanted to put them somewhere.

@snowystinger
Copy link
Member Author

Skeleton

Should be covered by the loading state of the cardview

FileTrigger

Not an S2 component yet

@snowystinger snowystinger changed the title chore: Test app add date time fields chore: Test app add missing components Aug 28, 2025
@rspbot
Copy link

rspbot commented Aug 28, 2025

@@ -26,6 +26,7 @@ import {
Menu,
MenuItem,
MenuTrigger,
NotificationBadge,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this ones missing an ActionBar import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants