Skip to content

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Aug 22, 2025

Description

Improving the accessibility documentation of components.

Related issue(s)

SWC-402

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Copy link

changeset-bot bot commented Aug 22, 2025

⚠️ No Changeset found

Latest commit: e1c005c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 22, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5709

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@cdransf cdransf force-pushed the cdransf/search-docs-audit branch 2 times, most recently from f3fe41e to 7578732 Compare August 27, 2025 15:50
@cdransf cdransf force-pushed the cdransf/search-docs-audit branch from c4e355e to 28cb36d Compare August 27, 2025 22:10
@cdransf cdransf force-pushed the cdransf/search-docs-audit branch from 28cb36d to e1c005c Compare August 28, 2025 12:43
Copy link
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice work! 🌟


The search field consists of several key parts:

- A label/search term
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this just be "Label" or "Label/placeholder"? search term isnt really a part but an value from an action. could be overthinking it

Also can we remove "A" and "An" since its a bulleted list?


#### Sizes

Search fields come in four different sizes for mobile and desktop platform scales: small, medium, large, and extra-large. The medium size is the default and most frequently used option.
Copy link
Contributor

@caseyisonit caseyisonit Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Search fields come in four different sizes for mobile and desktop platform scales: small, medium, large, and extra-large. The medium size is the default and most frequently used option.
Search fields come in four different sizes for mobile and desktop platform scales: `small`, `medium`, `large`, and `extra-large`.
The default and most frequently used size is `medium`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants