-
Notifications
You must be signed in to change notification settings - Fork 233
docs(search): update a11y docs #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
f3fe41e
to
7578732
Compare
c4e355e
to
28cb36d
Compare
28cb36d
to
e1c005c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Nice work! 🌟
|
||
The search field consists of several key parts: | ||
|
||
- A label/search term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this just be "Label" or "Label/placeholder"? search term isnt really a part but an value from an action. could be overthinking it
Also can we remove "A" and "An" since its a bulleted list?
|
||
#### Sizes | ||
|
||
Search fields come in four different sizes for mobile and desktop platform scales: small, medium, large, and extra-large. The medium size is the default and most frequently used option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Search fields come in four different sizes for mobile and desktop platform scales: small, medium, large, and extra-large. The medium size is the default and most frequently used option. | |
Search fields come in four different sizes for mobile and desktop platform scales: `small`, `medium`, `large`, and `extra-large`. | |
The default and most frequently used size is `medium`. |
Description
Improving the accessibility documentation of components.
Related issue(s)
SWC-402
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresDevice review