-
Notifications
You must be signed in to change notification settings - Fork 233
bug(slider): remove jsdoc slot deprecation comment in slider #5713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(slider): remove jsdoc slot deprecation comment in slider #5713
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!!
Description
When importing the
Slider
component the alias class would appear deprecated because the JS doc included adeprecated
flag stating the text content as a slot is no longer used, consumers must use thelabel
property instead.Motivation and context
We don't want consumers to think the
Slider
is deprecated entirely. It'll appear broken in their IDEs.Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresScreenshot