Skip to content

Conversation

aramos-adobe
Copy link
Contributor

@aramos-adobe aramos-adobe commented Aug 26, 2025

Description

When importing the Slider component the alias class would appear deprecated because the JS doc included a deprecated flag stating the text content as a slot is no longer used, consumers must use the label property instead.

Motivation and context

We don't want consumers to think the Slider is deprecated entirely. It'll appear broken in their IDEs.

Related issue(s)

  • fixes SWC-1040

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Screenshot

Screenshot 2025-08-26 at 12 43 07 PM

@aramos-adobe aramos-adobe requested a review from a team as a code owner August 26, 2025 17:05
Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: 83b4dac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aramos-adobe aramos-adobe self-assigned this Aug 26, 2025
@aramos-adobe aramos-adobe added bug Something isn't working ready-for-review labels Aug 26, 2025
Copy link
Contributor

github-actions bot commented Aug 26, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5713

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Contributor

@caseyisonit caseyisonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!!

@aramos-adobe aramos-adobe merged commit 01220fe into main Aug 28, 2025
24 checks passed
@aramos-adobe aramos-adobe deleted the aramos-adobe/swc1040-slider-deprecation-flag-bug branch August 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants