246 write an architecture document for didcomm mediator server e13 #269
+658
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-server-e13' of github.com:adorsys/didcomm-mediator-rs into 246-write-an-architecture-document-for-didcomm-mediator-server-e13
…-server-e13' of github.com:adorsys/didcomm-mediator-rs into 246-write-an-architecture-document-for-didcomm-mediator-server-e13
Signed-off-by: Francis Pouatcha <francis.pouatcha@adorsys.com>
merging from main
Tekum-Emmanuella
requested review from
francis-pouatcha,
IngridPuppet,
Hermann-Core,
Christiantyemele,
Blindspot22 and
ndefokou
7 tasks
Christiantyemele
requested changes
Nov 25, 2024
Blindspot22
requested changes
Nov 26, 2024
Blindspot22
approved these changes
Dec 5, 2024
ndefokou
approved these changes
Dec 13, 2024
Christiantyemele
requested changes
Dec 16, 2024
IngridPuppet
reviewed
Jan 5, 2025
There was a problem hiding this comment.
Many points raised in the documentation seem disconnected with what is implemented or planned to be implemented. I understand that a sizeable amount of them are wished features though... So I would suggest to ensure we have proper discussion and tickets for those ahead, otherwise it is preferable to dismiss them.
Comment on lines
+53
to
+54
| - **Transport Protocols**: Various transport layers, e.g., HTTP or WebSockets. | ||
| - **Cloud Infrastructure**: For scalable and fault-tolerant deployments. |
There was a problem hiding this comment.
Can you really consider that the system is interacting with a transport protocol and a cloud infrastructure, considering such as external entities?
|
@chendiblessing - Are you sure you pushed your changes? I am nearly seeing none of my comments addressed. Also note that you should provide responses to the points you leave unaddressed, explaining why. |
Christiantyemele
requested changes
Jan 15, 2025
Co-authored-by: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com>
Co-authored-by: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com>
Co-authored-by: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com>
Co-authored-by: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please @ all, read this arc doc so we can review together and merge.