Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intergration env support #283

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Conversation

Christiantyemele
Copy link
Collaborator

@Christiantyemele Christiantyemele commented Dec 5, 2024

This is the architecture followed for the mediator delployment: current implementation can be found on page2 here

…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
@Blindspot22 Blindspot22 added enhancement New feature or request devOps deployment/intergration related labels Dec 17, 2024
@chendiblessing chendiblessing marked this pull request as draft December 18, 2024 15:02
@chendiblessing chendiblessing marked this pull request as ready for review December 19, 2024 15:09
Copy link
Collaborator

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 good to go.
I think, you should squash some of the commits into a single commit or segment, because some of them don't make sense individually and a couple of repetitions.
e.g 12 commits bearing the same name :)

@ndefokou
Copy link
Collaborator

Fixed the conflicts and after that i will approve the ticket

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this folder and the containing file. We don't need it.

.dockerignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Comment on lines +6 to +19
# Copy Cargo files and crates (this helps with caching dependencies)
COPY Cargo.toml Cargo.lock ./
COPY src ./src
COPY crates ./crates

# Pre-cache dependencies and build the project
RUN cargo fetch && cargo build --release

# Dynamically mount source code during build for easy updates
VOLUME /app

# Ensure the binary is built and available
CMD cargo build --release && \
cp target/release/didcomm-mediator /usr/local/bin/didcomm-mediator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leverage build caching to speed up the build process. I also suggest using the alpine version of the builder image as it will enable us to easily construct the final application image with an alpine base, resulting in the lowest possible image size.

Dockerfile Outdated
EXPOSE 3000

# Set the entrypoint for the application
ENTRYPOINT ["didcomm-mediator"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous comment, we could use the Alpine image as our application base image. Additionally, it is advisable to create a new non-privileged user for the application to run under for security purposes.

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devOps deployment/intergration related enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Environment for DIDComm Mediator Server Deployment E6
5 participants