-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intergration env support #283
base: main
Are you sure you want to change the base?
Conversation
…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
…into 245-integration-environment-for-didcomm-mediator-server-deployment-e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍 good to go.
I think, you should squash some of the commits into a single commit or segment, because some of them don't make sense individually and a couple of repetitions.
e.g 12 commits bearing the same name :)
Fixed the conflicts and after that i will approve the ticket |
…/didcomm-mediator-rs into intergration-env-support
.debug/.rustc_info.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this folder and the containing file. We don't need it.
# Copy Cargo files and crates (this helps with caching dependencies) | ||
COPY Cargo.toml Cargo.lock ./ | ||
COPY src ./src | ||
COPY crates ./crates | ||
|
||
# Pre-cache dependencies and build the project | ||
RUN cargo fetch && cargo build --release | ||
|
||
# Dynamically mount source code during build for easy updates | ||
VOLUME /app | ||
|
||
# Ensure the binary is built and available | ||
CMD cargo build --release && \ | ||
cp target/release/didcomm-mediator /usr/local/bin/didcomm-mediator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leverage build caching to speed up the build process. I also suggest using the alpine version of the builder image as it will enable us to easily construct the final application image with an alpine base, resulting in the lowest possible image size.
Dockerfile
Outdated
EXPOSE 3000 | ||
|
||
# Set the entrypoint for the application | ||
ENTRYPOINT ["didcomm-mediator"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the previous comment, we could use the Alpine image as our application base image. Additionally, it is advisable to create a new non-privileged user for the application to run under for security purposes.
This is the architecture followed for the mediator delployment: current implementation can be found on page2 here