feat: move core dynamo interfaces to dynamo core [DONT MERGE]

[biswapanda]

Overview:

Move core constructs for decoupled dynamo interfacesinto a dynamo into dynamo core.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[ishandhanani]

Why is this moving into dynamo core? The core should be the rust and the bindings on top of rust. I would expect this code to be a part of the SDK

[biswapanda]

Why is this moving into dynamo core? The core should be our the rust and the bindings on top of rust. I would expect this code to be a part of the SDK

@ishandhanani, we think this aligns with core because decoupled dynamo interfaces and decorators are core functionality for locally serving a dynamo. Deployment specific code is left in deploy folder. we moved away from language specific folder structure to functionality based folder structure. currently core contains some c, rust and python files as well.

[grahamking]

I agree with @ishandhanani . I think you are making a mistake calling these bits core and sdk and now core_sdk. It screams "this is important!" but doesn't tell the user why or what it does.

"deploy" is a good name. "run" is an acceptable name. Figure out what this does and call it that. If it's not easy to figure out what it does, consider splitting it, or re-working it, to make its purpose clear.

"core" is a bad name for obvious reasons.

"SDK" is a bad name because it isn't one - see wikipedia SDK entry. "Dynamo SDK" would imply there is a thing called Dynamo that you use the SDK to write software for, like a device or platform. Our github description says Dynamo is a framework. Framework's don't have SDKs.

Maybe this should be "dynamo graph"? Is being able to connect things the way this helps people?

@nnshah1 for viz

[biswapanda]

Agreed, we need to think through the name and location of the common interface/implementation of previously deploy/sdk bits.

[nnshah1]

Let's find some time next week - how urgent is this?

[biswapanda]

Let's find some time next week - how urgent is this?

yes, we can discuss the the destination directory for dynamo graphs next week. It's not super urgent.