Skip to content

feat(sglang): add dockerfile/pyproject toml entry + steps to run dsr1 disagg #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 27, 2025
Merged

feat(sglang): add dockerfile/pyproject toml entry + steps to run dsr1 disagg #1193

merged 19 commits into from
May 27, 2025

Conversation

ishandhanani
Copy link
Contributor

@ishandhanani ishandhanani commented May 23, 2025 •
edited
Loading

This PR

  1. Builds off of the work done by @thesues in build: Add minimal sglang Dockerfile #1112 and adds a Dockerfile.sglang. Agg/disagg examples work
  2. Adds a [sglang] field to the pyproject toml
  3. Adds instructions for running DSR1 multinode with SGLang (no deep ep support yet)

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the feat label May 23, 2025
nnshah1
nnshah1 reviewed May 27, 2025
View reviewed changes
nnshah1
nnshah1 reviewed May 27, 2025
View reviewed changes
nnshah1
nnshah1 reviewed May 27, 2025
View reviewed changes
nnshah1
nnshah1 approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - will need to add tests into ci

ishandhanani and others added 4 commits May 27, 2025 11:14
@ishandhanani @nnshah1
Update examples/sglang/README.md
0fedad6 
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Signed-off-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
@ishandhanani @nnshah1
Update examples/sglang/README.md
3db6219 
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Signed-off-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
@ishandhanani
fix
75fb4a3
@ishandhanani
Merge branch 'ishan/sgl-setup' of github.com:ai-dynamo/dynamo into is…
3d0b086 
…han/sgl-setup
@ishandhanani ishandhanani enabled auto-merge (squash) May 27, 2025 18:22
@ishandhanani ishandhanani disabled auto-merge May 27, 2025 19:03
@ishandhanani ishandhanani enabled auto-merge (squash) May 27, 2025 22:34
@ishandhanani ishandhanani merged commit 5c5cec3 into main May 27, 2025
5 checks passed
@ishandhanani ishandhanani deleted the ishan/sgl-setup branch May 27, 2025 23:11
pvijayakrish pushed a commit that referenced this pull request May 29, 2025
@ishandhanani @nnshah1 @pvijayakrish
feat(sglang): add dockerfile/pyproject toml entry + steps to run dsr1…
0883ae5 
… disagg (#1193)

Signed-off-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnshah1 nnshah1 nnshah1 approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@grahamking grahamking Awaiting requested review from grahamking grahamking is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@sshchoi sshchoi Awaiting requested review from sshchoi sshchoi is a code owner

@PeaBrane PeaBrane Awaiting requested review from PeaBrane PeaBrane is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees
No one assigned
Labels
feat size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishandhanani @nnshah1