NIXL POSIX plugin #178
Merged
NIXL POSIX plugin #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi dfarge! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
dfarge
force-pushed
the
posix
branch
2 times, most recently
from
383770e to
8dd6965
Compare
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
etoledano
reviewed
Apr 22, 2025
dfarge
force-pushed
the
posix
branch
11 times, most recently
from
2760b4d to
0b6e641
Compare
|
Some comments has been marked resolved without a fix or a respond |
etoledano
reviewed
Apr 28, 2025
|
@tstamler can you review to see if the change request has been addressed? |
dfarge
force-pushed
the
posix
branch
7 times, most recently
from
806bc95 to
bced7d8
Compare
|
/ok to test bced7d8 |
tstamler
reviewed
Apr 30, 2025
tstamler
reviewed
Apr 30, 2025
tstamler
reviewed
Apr 30, 2025
There was a problem hiding this comment.
I left a couple of comments around documentation. I think the biggest open TODO is to add to CI. We want all in-tree plugins to be included and tested in CI, just running the test you already have should be good enough. I will discuss with @vvenkates27 how we want to do this.
|
and then, obviously there is also the fact that it doesn't build in the current CI, which is not good |
tstamler
reviewed
Apr 30, 2025
|
/ok to test c61ee94 |
tstamler
approved these changes
May 1, 2025
tstamler
added a commit
that referenced
this pull request
May 1, 2025
* NIXL POSIX plugin (#178) * Added status.h header, containing useful macros for checking nixl_status_t * CI: test liburing install and run posix_test Signed-off-by: Timothy Stamler <tstamler@nvidia.com> Co-authored-by: dfarge <dfarge@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a plugin to support POSIX type files.