-
Notifications
You must be signed in to change notification settings - Fork 53
API: checkRemoteMD call #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tstamler
commented
Apr 25, 2025
•
edited
Loading
edited
- add method to check if a remote agent's metadata is available
- Rearrange metadata methods for consistency
2b7598c
to
23a7885
Compare
23a7885
to
0caa900
Compare
0caa900
to
3893a40
Compare
3893a40
to
120bc74
Compare
mkhazraee
approved these changes
Apr 26, 2025
120bc74
to
5aa9bc8
Compare
5aa9bc8
to
009e15c
Compare
/ok to test 5abaf87 |
Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
* As well as minor reordering of the API Signed-off-by: Moein Khazraee <moein@nvidia.com>
a208899
to
fe4f251
Compare
aranadive
approved these changes
Apr 28, 2025
tstamler
added a commit
that referenced
this pull request
Apr 28, 2025
* API: checkRemoteMD call Signed-off-by: Timothy Stamler <tstamler@nvidia.com> * API: added descs to checkRemoteMD * As well as minor reordering of the API Signed-off-by: Timothy Stamler <tstamler@nvidia.com> Signed-off-by: Moein Khazraee <moein@nvidia.com> Co-authored-by: Moein Khazraee <moein@nvidia.com>
tstamler
added a commit
that referenced
this pull request
Apr 29, 2025
* API: checkRemoteMD call Signed-off-by: Timothy Stamler <tstamler@nvidia.com> * API: added descs to checkRemoteMD * As well as minor reordering of the API Signed-off-by: Timothy Stamler <tstamler@nvidia.com> Signed-off-by: Moein Khazraee <moein@nvidia.com> Co-authored-by: Moein Khazraee <moein@nvidia.com>
saturley-hall
pushed a commit
that referenced
this pull request
Apr 29, 2025
…218) * API: checkRemoteMD call (#203) * API: checkRemoteMD call Signed-off-by: Timothy Stamler <tstamler@nvidia.com> * API: added descs to checkRemoteMD * As well as minor reordering of the API Signed-off-by: Timothy Stamler <tstamler@nvidia.com> Signed-off-by: Moein Khazraee <moein@nvidia.com> Co-authored-by: Moein Khazraee <moein@nvidia.com> * Add ETCD support for NIXL MD (#199) Added etcd Support for Metadata Storage and Retrieval - etcd Dependencies: - Integrated etcd dependencies into the project using the Meson build system and Dockerfile. - Made etcd support optional based on the availability of the etcd C++ API. - etcd Functions: - Added functions to store and retrieve metadata (MD) using a key-value model with namespace-based separation. - Enabled agent system to interact with etcd for adding/removing keys. - Agent and Configuration: - Simplified agent creation to include etcd support, utilizing environment variables and endpoint information. - Removed custom config for etcd, relying on environment variables for server connection and namespace setup. - Threading and Comm Work: - Adjusted threading model to allow etcd operations (add, fetch, remove keys) to run on the communication worker thread, separate from the listener thread. - Implemented support for watching keys and invalidating metadata with special key handling. - Examples and Documentation: - Added agent-based examples showcasing the use of etcd for storing and retrieving metadata, including single transfer operations. - Updated README with instructions on building etcd support and running examples. Signed-off-by: Adit Ranadive <aranadive@nvidia.com> --------- Signed-off-by: Timothy Stamler <tstamler@nvidia.com> Signed-off-by: Moein Khazraee <moein@nvidia.com> Signed-off-by: Adit Ranadive <aranadive@nvidia.com> Co-authored-by: Moein Khazraee <moein@nvidia.com> Co-authored-by: Adit Ranadive <aranadive@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.