Skip to content

API: checkRemoteMD call #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2025
Merged

API: checkRemoteMD call #203

merged 10 commits into from
Apr 28, 2025

Conversation

tstamler
Copy link
Collaborator

@tstamler tstamler commented Apr 25, 2025

  • add method to check if a remote agent's metadata is available
  • Rearrange metadata methods for consistency

@tstamler tstamler requested a review from mkhazraee April 25, 2025 22:22
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 25, 2025
@mkhazraee mkhazraee force-pushed the tstamler/check_md_API branch from 2b7598c to 23a7885 Compare April 25, 2025 23:16
@mkhazraee mkhazraee force-pushed the tstamler/check_md_API branch from 23a7885 to 0caa900 Compare April 25, 2025 23:19
@mkhazraee mkhazraee force-pushed the tstamler/check_md_API branch from 0caa900 to 3893a40 Compare April 25, 2025 23:22
@mkhazraee mkhazraee force-pushed the tstamler/check_md_API branch from 3893a40 to 120bc74 Compare April 25, 2025 23:51
@tstamler tstamler marked this pull request as ready for review April 26, 2025 00:36
@mkhazraee mkhazraee closed this Apr 26, 2025
@mkhazraee mkhazraee reopened this Apr 26, 2025
@tstamler
Copy link
Collaborator Author

/ok to test 5abaf87

tstamler and others added 5 commits April 28, 2025 10:51
Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
* As well as minor reordering of the API

Signed-off-by: Moein Khazraee <moein@nvidia.com>
Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
@tstamler tstamler merged commit 9f223f4 into main Apr 28, 2025
7 checks passed
@tstamler tstamler deleted the tstamler/check_md_API branch April 28, 2025 20:06
tstamler added a commit that referenced this pull request Apr 28, 2025
* API: checkRemoteMD call

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>

* API: added descs to checkRemoteMD
* As well as minor reordering of the API

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
Signed-off-by: Moein Khazraee <moein@nvidia.com>
Co-authored-by: Moein Khazraee <moein@nvidia.com>
tstamler added a commit that referenced this pull request Apr 29, 2025
* API: checkRemoteMD call

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>

* API: added descs to checkRemoteMD
* As well as minor reordering of the API

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
Signed-off-by: Moein Khazraee <moein@nvidia.com>
Co-authored-by: Moein Khazraee <moein@nvidia.com>
saturley-hall pushed a commit that referenced this pull request Apr 29, 2025
…218)

* API: checkRemoteMD call (#203)

* API: checkRemoteMD call

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>

* API: added descs to checkRemoteMD
* As well as minor reordering of the API

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
Signed-off-by: Moein Khazraee <moein@nvidia.com>
Co-authored-by: Moein Khazraee <moein@nvidia.com>

* Add ETCD support for NIXL MD (#199)

Added etcd Support for Metadata Storage and Retrieval
- etcd Dependencies:
   - Integrated etcd dependencies into the project using the Meson build system and Dockerfile.
   - Made etcd support optional based on the availability of the etcd C++ API.

- etcd Functions:
   - Added functions to store and retrieve metadata (MD) using a key-value model with namespace-based separation.
   - Enabled agent system to interact with etcd for adding/removing keys.

- Agent and Configuration:
   - Simplified agent creation to include etcd support, utilizing environment variables and endpoint information.
   - Removed custom config for etcd, relying on environment variables for server connection and namespace setup.

- Threading and Comm Work:
   - Adjusted threading model to allow etcd operations (add, fetch, remove keys) to run on the communication worker thread, separate from the listener thread.
   - Implemented support for watching keys and invalidating metadata with special key handling.

- Examples and Documentation:
   - Added agent-based examples showcasing the use of etcd for storing and retrieving metadata, including single transfer operations.
  - Updated README with instructions on building etcd support and running examples.

Signed-off-by: Adit Ranadive <aranadive@nvidia.com>

---------

Signed-off-by: Timothy Stamler <tstamler@nvidia.com>
Signed-off-by: Moein Khazraee <moein@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Co-authored-by: Moein Khazraee <moein@nvidia.com>
Co-authored-by: Adit Ranadive <aranadive@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants