Skip to content

Add "support" for UCX v1.19 in terms of disabling the CUDA pointer workaround #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: pull-request/227
Choose a base branch
from
Draft

Add "support" for UCX v1.19 in terms of disabling the CUDA pointer workaround #244

wants to merge 3 commits into from

Conversation

artpol84
Copy link
Contributor

@artpol84 artpol84 commented May 3, 2025 •
edited
Loading

This PR depends on #227 (the first commit is from that PR).

artpol84 added 2 commits May 1, 2025 01:22
@artpol84
utils: Introduce CUDA util component & cleanup meson infra
b4185dd 
Abstract CUDA functionality leveraged by some of the
backends, specifically, UCX.

The CUDA util comonent gets build regardless of CUDA presense
and allows to focus all CUDA-related logic and complexity
within one place.

Also optimize some of the meson build files to expose
and propagate internal component dependencies.

Signed-off-by: Artem Y. Polyakov <artemp@nvidia.com>
@artpol84
Detect support for multi-context in UCX
d4a336b
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@artpol84 artpol84 marked this pull request as draft May 3, 2025 04:54
@artpol84
Copy link
Contributor Author

artpol84 commented May 3, 2025

/ok to test de5d05b

@tstamler
Copy link
Contributor

tstamler commented May 5, 2025

This PR depends on #227 (the first commit is from that PR).

I'm going to change the base to that branch to isolate the changes here. Github should automatically handle the rebase for you if the underlying PR is merged.

@tstamler tstamler changed the base branch from main to pull-request/227 May 5, 2025 13:43
@tstamler
Copy link
Contributor

tstamler commented May 5, 2025

Also commenting that the goal is to address this issue: #202

But we can probably now also address this issue, maybe in this PR if you think its simple enough: #166

@artpol84 artpol84 changed the title Topic/ucx multi gpu/final Add "support" for UCX v1.19 in terms of disabling the CUDA pointer workaround May 6, 2025
This was referenced May 6, 2025
Open
Open
@copy-pr-bot copy-pr-bot bot force-pushed the pull-request/227 branch 5 times, most recently from bc7d1c5 to 87a3bf4 Compare May 9, 2025 19:06
@artpol84 artpol84 self-assigned this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@artpol84 artpol84

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artpol84 @tstamler