Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Aim web ui integration in jupyter/colab #3319

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

larissapoghosyan
Copy link
Contributor

The PR #2696 added more robust mechanism of initializing aim server, checking the health, and only then enabling the web ui. However, there's no endpoint /projects/status/ now as part of api, so currently aim web ui integration for jupyter always fails.

This PR:

  • Relies on status code of /projects endpoint instead
  • Removes unnecessary delay in case of failure (for loop always calling sleep even if no tries left)
  • Implements delayed retries with exponential backoff, and lets it to wait longer, as some google colab machines are slow and take at least 10-15 seconds to start the aim server.

Possibly addresses #2672 and #3123

Tested on both local jupyter notebooks, and google colab

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alberttorosyan alberttorosyan changed the title [fix] aim web ui integration in jupyter/colab [fix] Aim web ui integration in jupyter/colab Apr 7, 2025
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larissapoghosyan, thanks for your contribution!
Approving this PR since the failure of code style checks is not related to this change.

@alberttorosyan alberttorosyan merged commit 9ee40a2 into aimhubio:main Apr 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants