-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significantly improve performance of the unquoter #1496
Conversation
CodSpeed Performance ReportMerging #1496 will improve performances by 85.67%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (98.07%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1496 +/- ##
=======================================
Coverage 98.92% 98.93%
=======================================
Files 32 32
Lines 6074 6087 +13
Branches 365 365
=======================================
+ Hits 6009 6022 +13
Misses 62 62
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
unsafe
can only be extended ascii (0-255) so this check can be a bit cheaper as we can do char compares and avoid calling__Pyx_UnicodeContainsUCS4