Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct coverage for unquoter with plus=True #1497

Merged
merged 2 commits into from
Apr 6, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 6, 2025

followup to #1493

While the tests would already fail if this didn't work, its good to have some direct coverage as well.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 6, 2025
@bdraco bdraco marked this pull request as ready for review April 6, 2025 00:18
@bdraco bdraco enabled auto-merge (squash) April 6, 2025 00:18
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (3bf614a) to head (2499246).
Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (98.07%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1497   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          32       32           
  Lines        6070     6074    +4     
  Branches      365      365           
=======================================
+ Hits         6005     6009    +4     
  Misses         62       62           
  Partials        3        3           
Flag Coverage Δ
CI-GHA 98.92% <100.00%> (+<0.01%) ⬆️
MyPy 98.07% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.78% <100.00%> (+<0.01%) ⬆️
OS-Windows 98.82% <100.00%> (+<0.01%) ⬆️
OS-macOS 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 98.74% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 98.74% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.54% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 98.74% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 98.74% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.50% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 98.70% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 98.69% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.19 98.71% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 98.56% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 98.78% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 98.82% <100.00%> (+<0.01%) ⬆️
pytest 98.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Apr 6, 2025

CodSpeed Performance Report

Merging #1497 will not alter performance

Comparing unquote_plus_tests (2499246) with master (3bf614a)

Summary

✅ 101 untouched benchmarks

@bdraco bdraco merged commit 99079e3 into master Apr 6, 2025
48 of 50 checks passed
@bdraco bdraco deleted the unquote_plus_tests branch April 6, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant