Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version to 1.19.1.dev0 #1500

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Increment version to 1.19.1.dev0 #1500

merged 1 commit into from
Apr 6, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 6, 2025

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Apr 6, 2025
Copy link

codspeed-hq bot commented Apr 6, 2025

CodSpeed Performance Report

Merging #1500 will degrade performances by 66.38%

Comparing inc_ver_1191 (a55a93a) with master (116dbda)

Summary

❌ 36 (👁 36) regressions
✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_long_query 2 ms 5.9 ms -66.38%
👁 test_long_query_with_pct 8.9 ms 17.9 ms -50.47%
👁 test_quote_long_path 1.6 ms 4.8 ms -66.3%
👁 test_quote_query_string 133.2 µs 312.5 µs -57.36%
👁 test_quoter_ascii 66.8 µs 123.9 µs -46.07%
👁 test_quoter_pct 130.9 µs 244.5 µs -46.46%
👁 test_quoter_quote_utf8 315.1 µs 683.5 µs -53.9%
👁 test_unquoter_long_ascii 4.6 ms 12.1 ms -61.89%
👁 test_unquoter_long_pct 7.2 ms 15 ms -51.84%
👁 test_unquoter_short 119.1 µs 203.4 µs -41.42%
👁 test_extend_query_subclassed_str 833.1 µs 1,004.9 µs -17.1%
👁 test_parse_query_uncached[long] 14.7 ms 20.9 ms -29.79%
👁 test_parse_query_uncached[short] 1.2 ms 1.7 ms -27.96%
👁 test_path_safe_uncached 165.3 µs 232.1 µs -28.77%
👁 test_update_query_mapping 785 µs 926.4 µs -15.26%
👁 test_update_query_mapping_with_existing_query 1 ms 1.2 ms -18.74%
👁 test_update_query_sequence_mapping 3.1 ms 4.5 ms -30.56%
👁 test_update_query_string 530.7 µs 601.4 µs -11.75%
👁 test_url_build_access_raw_path 528.4 µs 586.3 µs -9.87%
👁 test_url_build_no_netloc 343.7 µs 422.8 µs -18.69%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (116dbda) to head (a55a93a).
Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (98.07%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          32       32           
  Lines        6091     6091           
  Branches      365      365           
=======================================
  Hits         6026     6026           
  Misses         62       62           
  Partials        3        3           
Flag Coverage Δ
CI-GHA 98.93% <100.00%> (ø)
MyPy 98.07% <100.00%> (ø)
OS-Linux 98.78% <100.00%> (ø)
OS-Windows 98.82% <100.00%> (ø)
OS-macOS 98.56% <100.00%> (ø)
Py-3.10.11 98.54% <100.00%> (ø)
Py-3.10.16 98.74% <100.00%> (ø)
Py-3.11.11 98.74% <100.00%> (ø)
Py-3.11.9 98.54% <100.00%> (ø)
Py-3.12.9 98.74% <100.00%> (ø)
Py-3.13.2 98.74% <100.00%> (ø)
Py-3.9.13 98.50% <100.00%> (ø)
Py-3.9.21 98.70% <100.00%> (ø)
Py-pypy7.3.16 98.69% <100.00%> (ø)
Py-pypy7.3.19 98.71% <100.00%> (ø)
VM-macos-latest 98.56% <100.00%> (ø)
VM-ubuntu-latest 98.78% <100.00%> (ø)
VM-windows-latest 98.82% <100.00%> (ø)
pytest 98.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
Copy link
Member Author

bdraco commented Apr 6, 2025

performance benchmarks are a side effect of Cython tracing being turned off for the release and than this PR ran right after

@bdraco bdraco marked this pull request as ready for review April 6, 2025 02:39
@bdraco bdraco merged commit 937f030 into master Apr 6, 2025
48 of 50 checks passed
@bdraco bdraco deleted the inc_ver_1191 branch April 6, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant