Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: middleware type hints #2033

Open
wants to merge 13 commits into
base: 0.6.0
Choose a base branch
from

Conversation

DABND19
Copy link

@DABND19 DABND19 commented Jan 11, 2025

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@DABND19 DABND19 marked this pull request as draft January 11, 2025 16:12
@DABND19 DABND19 force-pushed the fix/middleware-type-hints branch from 84da0a2 to 816affa Compare January 11, 2025 16:35
@DABND19 DABND19 force-pushed the fix/middleware-type-hints branch from 816affa to 35c6d1b Compare January 11, 2025 16:46
@DABND19 DABND19 marked this pull request as ready for review January 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant