1543 Fix access to get private file URLs #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Re #1543] We were not including the namespace that extends the GCSStorageClient protocol with the methods to get blob signed URL and delete blob-relate functionality, that was preventing the reading of private image files from GCS. This was not reproduced locally, since there we load always all the namespaces, which is not the case with the Uberjar. So now we require the mentioned file as part of the File service, that is required already, fixing the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Re #1543]
We were not including the namespace that extends the GCSStorageClient protocol with the methods to get blob signed URL and delete blob-related functionality, that was preventing the reading of private image files from GCS. This was not reproduced locally, since there we load always all the namespaces, which is not the case with the Uberjar. So now we require the mentioned file as part of the File service, that is required already, fixing the issue.