1638 Fix emptying tags in resource/org edition #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Re #1638] As described in the issue, now we check in the affected API endpoints whether we get the `tags` key at all in the payload, so we know if we need to remove all the tag relationships, add/remove some of them or we just ignore tags during the update (in case we do not receive such property at all). We have needed to update the generic tag update code to allow this use-case.
joseAyudarte91
deleted the
1638-fix-emptying-tags-for-resource-and-org-edition-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Re #1638]
As described in the issue, now we check in the affected API endpoints whether we get the
tagskey at all in the payload, so we know if we need to remove all the tag relationships, add/remove some of them or we just ignore tags during the update (in case we do not receive such property at all).We have needed to update the generic tag update code to allow this use-case.