Refactor Product With Children to remove Double Conversion

[natedawg92]

Summary

$this->getSpecialPrice() and $this->getTierPrice() Return a converted price when using multiple currencies, however these prices there converted again a little bit further down the function

Example: Base Currency GBP, Product Price 1200, also shows prices in EUR with a conversion rate of 1.2 (simplified numbers for example)

$this->getSpecialPrice() will return the Product Final price but converted (1200 * 1.2 = 1440) and then this gets converted again on line 72 (1440 * 1.2 = 1728) giving us an incorrect amount.

I have refactored the currency conversion to convert just the final Price and Base Price so that if a special price / Tiered price returns a value then these are converted twice.

Result

prices are only converted when necessary so they are only converted once.