Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] NodeEditor: Don't allow to reduce split view size below 350 #2699

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cbentejac
Copy link
Contributor

Description

This prevents reducing the Node Editor up to the point where components within it (especially in its header) are disappearing from screen.

@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Mar 18, 2025
@cbentejac cbentejac requested a review from fabiencastan March 18, 2025 15:52
@cbentejac cbentejac self-assigned this Mar 18, 2025
@cbentejac cbentejac added the UI label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (08614a3) to head (bc91bab).
Report is 14 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2699      +/-   ##
===========================================
+ Coverage    73.39%   73.43%   +0.04%     
===========================================
  Files          133      134       +1     
  Lines         7911     7924      +13     
===========================================
+ Hits          5806     5819      +13     
  Misses        2105     2105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant