Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to PSR-4 for tests #282

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Migrating to PSR-4 for tests #282

merged 3 commits into from
Nov 21, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 20, 2023

Migrating to a PSR-4 folder structure for tests.

Powered by https://github.com/alleyinteractive/wp-to-psr-4

Summary by CodeRabbit

  • Refactor

    • Improved naming conventions for test classes to enhance readability and consistency.
  • Chores

    • Updated code standards configuration to exclude test files from specific naming rules.

Copy link

coderabbitai bot commented Nov 20, 2023

Walkthrough

The changes across the files reflect a standardization effort within a WordPress plugin's codebase, focusing on naming conventions. Specifically, the updates involve renaming test classes to adhere to a more consistent and conventional naming pattern, and updating the configuration to exclude certain files from specific coding standards checks.

Changes

File Path Change Summary
.phpcs.xml Added exclusion pattern for "WordPress.Files.FileName" rule for files in "tests/" directory.
tests/.../ExampleFeatureTest.php
tests/TestCase.php
tests/.../ExampleUnitTest.php
Renamed test classes to follow conventional naming patterns.

🐇🌼 In the code's garden, names bloom anew,
Tests renamed, a fresh morning dew.
As autumn leaves code review,
A rabbit hops by, with refactorings true. 🍂🛠️


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 62b818d and 45c7a7b.
Files ignored due to filter (1)
  • composer.json
Files selected for processing (4)
  • .phpcs.xml (1 hunks)
  • tests/Feature/ExampleFeatureTest.php (1 hunks)
  • tests/TestCase.php (1 hunks)
  • tests/Unit/ExampleUnitTest.php (1 hunks)
Files skipped from review due to trivial changes (4)
  • .phpcs.xml
  • tests/Feature/ExampleFeatureTest.php
  • tests/TestCase.php
  • tests/Unit/ExampleUnitTest.php

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srtfisher srtfisher merged commit 31480a6 into develop Nov 21, 2023
8 checks passed
@srtfisher srtfisher deleted the feature/psr-4-tests branch November 21, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants