Limiter and Compressor filters #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! If you don't mind, I'll wait for #148 to be merged and this one to be rebased so that I can have a cleaner view of the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Limiter and Compressor filters.
Happens that playing multiple sounds at the same time can create noise and output distortion. The limiter or the compressor filter can be used to reduce this behavior.
I think the compressor is better suited for games.
Both come with an example in the
example/lib/filtersdir. Both examples play the same audio at the same time to gain a high and distorted volume. The sliders are used to arrange the filter parameters and find which values are the best to use.Type of Change
I tried to do the limiter filter, but I wasn't happy with the results it can have for your use case. So I've also made a compressor filter that may work better for you. I just pushed a PR but starting this I merged the
websocketinto this new PR and I think you will also see the other changes. Anyway, there is not much Dart code in that to review. So I think it is better first to review thewebsocket(wrong branch name anyway :) ) and then just try the filters PR.